Repository navigation
linux: document and simplify the dso_debug code - #221
Merged
Merged
Conversation
schopin-mozilla
force-pushed
the
pod-dso-debug
branch
2 times, most recently
from
August 25, 2026 15:26
76c1145 to
6252144
Compare
marti4d
approved these changes
Aug 25, 2026
Collaborator
There was a problem hiding this comment.
Nice! And glad to see you fixed up and added all the comments too :)
Collaborator
|
(As you said -- we should hold off on landing this until #220 is landed) |
Co-authored-by: Chris Martin <marti4d@live.ca>
If we're going to read it from a crashing process, we can't really trust its data, which means we can't safely deserialize it into an enum: it's straight UB to build an enum value outside of its discriminant range.
`goblin::elf::Dyn` is pointer-width agnostic, but the in-memory value is *not*, which makes that type inappropriate as a basis to copy stuff over. Since it's the size used for 64-bit targets, it never showed on those architectures.
This simplifies the code a fair bit.
schopin-mozilla
force-pushed
the
pod-dso-debug
branch
from
August 26, 2026 08:33
6252144 to
5480cc2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We use the new
read_podto simplify the code.Split off #195 (sort of)
Do not merge before #220 !!