Repository navigation
linux: dso_debug: validate RDebug and LinkMap data when iterating them - #230
Merged
Merged
Conversation
schopin-mozilla
force-pushed
the
dso-debug-validation
branch
from
September 8, 2026 10:53
4f5d0d1 to
56b184a
Compare
schopin-mozilla
force-pushed
the
dso-debug-validation
branch
from
September 9, 2026 07:48
56b184a to
613bf05
Compare
gabrielesvelto
approved these changes
Sep 11, 2026
Contributor
There was a problem hiding this comment.
LGTM, just a small nit
schopin-mozilla
force-pushed
the
dso-debug-validation
branch
3 times, most recently
from
September 14, 2026 11:14
98c316c to
5d0d286
Compare
This data comes from a process that has potentially corrupted memory, it's probably a good idea to validate the data as much as possible. We also abstract LinkMap over the Iterator trait to make it easier to reuse it later on, e.g. for module list generation.
schopin-mozilla
force-pushed
the
dso-debug-validation
branch
from
September 14, 2026 16:23
5d0d286 to
69e3f8e
Compare
schopin-mozilla
changed the base branch from
dso-main-exec
to
dso-width-agnostic
September 14, 2026 16:23
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This data comes from a process that has potentially corrupted memory,
it's probably a good idea to validate the data as much as possible.
We also abstract LinkMap over the Iterator trait to make it easier to
reuse it later on, e.g. for module list generation.
Stack created with GitHub Stacks CLI • Give Feedback 💬