8000 linux: Enumerate mappings *after* suspending threads by schopin-mozilla · Pull Request #232 · rust-minidump/minidump-writer · GitHub
[go: up one dir, main page]
Skip to content

linux: Enumerate mappings *after* suspending threads #232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
schopin-mozilla merged 1 commit into from
Sep 17, 2026
Merged

linux: Enumerate mappings *after* suspending threads #232

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions src/linux/minidump_writer/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -298,11 +298,6 @@ impl MinidumpWriter {
soft_errors.push(InitError::EnumerateThreadsFailed(Box::new(e)));
}

// Same with mappings -- Some information is still better than no information!
if let Err(e) = self.enumerate_mappings() {
soft_errors.push(InitError::EnumerateMappingsFailed(Box::new(e)));
}

self.page_size = unsafe { libc::sysconf(libc::_SC_PAGESIZE).try_into().unwrap() };
assert!(
self.page_size > 0,
Expand All @@ -317,6 +312,11 @@ impl MinidumpWriter {
soft_errors.push(InitError::SuspendNoThreadsLeft(threads_count));
}

// Same with mappings -- Some information is still better than no information!
if let Err(e) = self.enumerate_mappings() {
soft_errors.push(InitError::EnumerateMappingsFailed(Box::new(e)));
}

// The module list is derived from mappings.
if let Err(e) = self.enumerate_modules(&mut soft_errors) {
soft_errors.push(InitError::EnumerateModulesFailed(Box::new(e)));
Expand Down
Loading
0