Repository navigation
mach: read_string: don't read unreadable memory - #250
Merged
gabrielesvelto merged 1 commit intoOct 26, 2026
Merged
Conversation
On my system, when trying to read the process exec path from the stack, it would systematically fail because it would include a guard page that sits right after the stack.
schopin-mozilla
force-pushed
the
macos-read-string
branch
from
October 26, 2026 11:20
75b02f8 to
70311be
Compare
Collaborator
Author
|
I think this might fix the issue that made us skip the CI on this test. |
schopin-mozilla
marked this pull request as ready for review
October 26, 2026 11:49
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On my system, when trying to read the process exec path from the stack, it would systematically fail because it would include a guard page that sits right after the stack.