8000 Added addIndexRight by briancaine · Pull Request #2140 · ramda/ramda · GitHub
[go: up one dir, main page]
Skip to content

Added addIndexRight - #2140

Merged
CrossEye merged 1 commit into
ramda:masterfrom
briancaine:feature/addIndexRight
Feb 5, 2022
Merged

Added addIndexRight#2140
CrossEye merged 1 commit into
ramda:masterfrom
briancaine:feature/addIndexRight

Conversation

@briancaine
@briancaine briancaine commented Mar 22, 2017
Copy link
Copy Markdown
Contributor

Implemented addIndexRight from #1898.

@briancaine
briancaine force-pushed the feature/addIndexRight branch 3 times, most recently from e2a07bb to 21e34f5 Compare March 22, 2017 23:46
@CrossEye
CrossEye commented Mar 24, 2017
Copy link
Copy Markdown
Member

LGTM

CrossEye
CrossEye previously approved these changes Jan 22, 2022
View reviewed changes
@CrossEye
CrossEye commented Jan 22, 2022
Copy link
Copy Markdown
Member

@briancaine: as with many issues around this time, this PR was totally dropped. Sorry about that. We're getting around to addressing all these old issues, and just came across this one.

If you're interested in pursuing it, could you fix the conflict in index.js? If not, feel free to close it.

@customcommander
customcommander commented Jan 23, 2022
Copy link
Copy Markdown
Member

@CrossEye Rebased against master and fixed the conflicts. Will fail until #3224 is merged.

@customcommander
customcommander commented Jan 24, 2022
Copy link
Copy Markdown
Member

@CrossEye Merge conflicts, lint and tests errors fixed. Good to go.

@CrossEye CrossEye self-assigned this Jan 27, 2022
CrossEye
CrossEye approved these changes Feb 5, 2022
View reviewed changes
@CrossEye CrossEye left a comment
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

🌿

@CrossEye
CrossEye merged commit c2cafc2 into ramda:master Feb 5, 2022
@customcommander customcommander added this to the 1.0.0 milestone Feb 6, 2022
@briancaine
briancaine deleted the feature/addIndexRight branch February 8, 2022 03:24
@adispring adispring mentioned this pull request Apr 7, 2023
Closed
@NOUIY NOUIY mentioned this pull request May 19, 2024
Open
@winston0410 winston0410 mentioned this pull request May 20, 2024
Open
@YoutacRandS-VA YoutacRandS-VA mentioned this pull request Jun 20, 2024
Open
@NOUIY NOUIY mentioned this pull request Jun 24, 2024
Open
@winston0410 winston0410 mentioned this pull request Jun 25, 2024
Open
@hashim21223445 hashim21223445 mentioned this pull request Jul 29, 2024
Merged
@funnsam funnsam mentioned this pull request Aug 2, 2024
Closed
@aakram786 aakram786 mentioned this pull request Aug 30, 2024
Open
@lokialone lokialone mentioned this pull request Sep 9, 2024
Open
@AKJUS AKJUS mentioned this pull request Sep 12, 2024
Open
This was referenced Sep 22, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@CrossEye CrossEye CrossEye approved these changes

Assignees

@CrossEye CrossEye

Labels

None yet

Projects

None yet

Milestone

v1.0

Development

Successfully merging this pull request may close these issues.

3 participants

@briancaine @CrossEye @customcommander
0