Repository navigation
fix: match drop transducer counts to list behavior - #3571
Open
LucasLeao18 wants to merge 1 commit into
Open
LucasLeao18 wants to merge 1 commit into
LucasLeao18 wants to merge 1 commit into
Conversation
Coverage Summary> ramda@0.32.0 coverage:summary
> BABEL_ENV=cjs nyc --reporter=text-summary mocha -- --reporter=min --require @babel/register
�[2J�[1;3H
1264 passing (802ms)
=============================== Coverage summary ===============================
Statements : 94.22% ( 2574/2732 )
Branches : 86.33% ( 1017/1178 )
Functions : 93.57% ( 568/607 )
Lines : 94.48% ( 2414/2555 )
================================================================================ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
R.drop(0.5, xs) preserves all elements through Array.slice, but R.into([], R.drop(0.5), xs) removes one. The transducer decrements the raw fractional count and effectively rounds positive counts upward.
Floor the transducer count so fractional counts match the existing list behavior. Add parity cases for fractional, integer, negative, NaN and infinite counts.
Validation (Node.js 24.15.0, Windows): The new parity regression fails before the fix. npm test passes: 1,265 tests and ESLint.
AI assistance: this contribution was prepared with OpenAI Codex; the change and regression results were reviewed before submission.