Repository navigation
fix: honor reduced values in reduceBy transducers - #3584
Open
abhinavrastogi2627 wants to merge 1 commit into
Open
abhinavrastogi2627 wants to merge 1 commit into
abhinavrastogi2627 wants to merge 1 commit into
Conversation
Coverage Summary> ramda@0.32.0 coverage:summary
> BABEL_ENV=cjs nyc --reporter=text-summary mocha -- --reporter=min --require @babel/register
�[2J�[1;3H
1264 passing (884ms)
=============================== Coverage summary ===============================
Statements : 94.22% ( 2574/2732 )
Branches : 86.33% ( 1017/1178 )
Functions : 93.57% ( 568/607 )
Lines : 94.48% ( 2414/2555 )
================================================================================ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
reduceBydocuments that its value reducer can returnR.reducedto stop iteration. Ordinary calls honor that signal, but transduced calls store the reduced wrapper as a group value and keep consuming input. Depending on the reducer, this either exposes the wrapper in the output or throws on the next input.Honor the reduced signal before recording the triggering value. Stop input consumption while allowing the transducer's normal completion phase to flush previously accumulated groups. This matches ordinary
reduceBy, including preserving an existing group and omitting a group first encountered at the stopping input.Add six regression cases covering
intoandtransduce, stopping in a new or existing group, immediate termination, and which input values were visited.Validation:
npm testpasses (1,270 tests and lint);npm run buildpasses.npm testpasses (1,268 tests, two existing regex-feature skips, and lint).git diff --checkpasses.