8000 Fix aperture transducers for oversized windows by jaredrainsha · Pull Request #3588 · ramda/ramda · GitHub
[go: up one dir, main page]

Skip to content

Fix aperture transducers for oversized windows - #3588

Open
jaredrainsha wants to merge 1 commit into
ramda:masterfrom
jaredrainsha:fix/aperture-transducer-large-windows
Open

jaredrainsha wants to merge 1 commit into
ramda:masterfrom
jaredrainsha:fix/aperture-transducer-large-windows

Conversation

@jaredrainsha
Copy link
Copy Markdown

Summary

  • Grow the aperture transducer's window as input arrives instead of allocating the requested size up front.
  • Return no windows for oversized or infinite window sizes when the input is shorter, matching direct aperture calls instead of throwing RangeError.
  • Preserve existing handling of other sizes, downstream completion, and early termination.

Validation

  • npm ci, npm test (1,279 passing), npm run lint, npm run build, npm run coverage:summary, and npm run coverage:details.
  • The 15 new regression cases went from 13 failing and 2 passing on the unmodified base to all 15 passing with the fix.
  • Compared the old and new transducers across ordinary window sizes, inputs, and early termination, and exercised the built CommonJS and ES modules.

AI disclosure

OpenAI Codex was used to prepare the implementation, tests, and PR text.

@github-actions
github-actions Bot commented Nov 6, 2026
Copy link
Copy Markdown
Coverage Summary
> ramda@0.32.0 coverage:summary
> BABEL_ENV=cjs nyc --reporter=text-summary mocha -- --reporter=min --require @babel/register

�[2J�[1;3H
1264 passing (878ms)


=============================== Coverage summary ===============================
Statements   : 94.22% ( 2574/2732 )
Branches     : 86.33% ( 1017/1178 )
Functions    : 93.57% ( 568/607 )
Lines        : 94.48% ( 2414/2555 )
================================================================================

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

0