Repository navigation
Fix bookmarklet generation with UglifyJS 3 - #3538
Merged
Merged
Conversation
Coverage Summary> ramda@0.32.0 coverage:summary
> BABEL_ENV=cjs nyc --reporter=text-summary mocha -- --reporter=min --require @babel/register
�[2J�[1;3H
1215 passing (873ms)
=============================== Coverage summary ===============================
Statements : 94.05% ( 2543/2704 )
Branches : 85.83% ( 993/1157 )
Functions : 93.39% ( 565/605 )
Lines : 94.31% ( 2385/2529 )
================================================================================ |
Contributor
|
ty for the PR. Please remove the updated BOOKMARKLET.md, I'll put up a patch release soon and it will get updated then |
Contributor
Author
|
Thanks — I’ll remove the |
Remove the unsupported fromString option and report minification errors before replacing the output. Cover successful execution and preservation of the previous file on failure.
ryanchou1994
force-pushed
the
fix/bookmarklet-generation
branch
from
September 14, 2026 15:51
b110739 to
2241995
Compare
Contributor
Author
|
Updated in |
kedashoe
approved these changes
Sep 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
npm run bookmarkletcurrently succeeds but writes an emptyjavascript:URL: UglifyJS 3 rejects the oldfromStringoption, and the script renders its missingcodeas empty text.Remove that option and stop on a minification error before overwriting the existing output. Add subprocess regressions for usable output, repeated execution, and preservation of the previous file on failure.
BOOKMARKLET.mdis intentionally left unchanged so the upcoming patch release can regenerate it.Fixes #3128.
Validation on the current revision, rebased on
f54129edee5bd9778c9c96668c0f17708d00f502:npm test: all 1,217 tests pass, including lint, on macOS with Node 22.23.2 and Linux with Node 24.20.0.npm run build: passes on both platforms.