Repository navigation
Add macOS Kerberos (GSSAPI) SSH authentication - #554
Open
ruofengOvO wants to merge 2 commits into
Open
ruofengOvO wants to merge 2 commits into
ruofengOvO wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Some SSH servers offer only
gssapi-with-mic. Add an opt-in Kerberos (GSSAPI) authentication choice for SSH hosts on macOS so Motty can use the existing system Kerberos credentials for those connections.The implementation uses Apple's GSS framework with the existing Go SSH client. It keeps host-key verification in the shared SSH handshake and leaves credential delegation disabled. The default authentication order stays the same.
The second commit applies
gofmtto an existing indentation issue onmainso the repository-wide format check passes.Validation
go vet ./....go test ./... -count=1run reported a stalled-upload cancellation timeout and a terminal drawing allocation assertion. Both packages passed on isolated reruns, and the two individual tests passed three consecutive reruns each.go test -race ./... -count=1run.