Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CMake installs libogg and its package files but leaves out ogg.m4. Autoconf consumers of that installation cannot find XIPH_PATH_OGG unless another Ogg installation happens to supply the macro.
Install the macro under the GNUInstallDirs data directory, matching the Autotools installation. Added a CI check for the installed file on Linux and macOS.
The install check fails before the fix. The Linux build, both CTest self-tests and an isolated aclocal/autoconf consumer pass after it. The consumer excludes system macro directories so an existing system ogg.m4 cannot hide the problem. Workflow YAML and diff checks pass; other platforms are left to CI.
Fixes #99.