8000 Keep GPU qualification inside its virtualenv by DaoyuanLi2816 · Pull Request #101 · DaoyuanLi2816/mini-verl · GitHub
[go: up one dir, main page]

Skip to content

Keep GPU qualification inside its virtualenv - #101

Merged
DaoyuanLi2816 merged 1 commit into
mainfrom
v0.11.0-qualifier-venv-fix
Aug 30, 2026
Merged

DaoyuanLi2816 merged 1 commit into
mainfrom
v0.11.0-qualifier-venv-fix

Conversation

@DaoyuanLi2816
Copy link
Copy Markdown
Owner

Summary

  • keep the GPU qualification interpreter path anchored inside .gpu-qualification-venv
  • stop resolving the venv python symlink to uv's externally managed base interpreter
  • add a workflow regression assertion for the interpreter-path contract

Reproduced failure

Fresh full qualification run 33282021980 failed before candidate installation because Path.resolve() converted the venv entry point into the uv-managed base Python and pip correctly refused it under PEP 668. No GPU benchmark or training workload ran in that failed attempt, and it was not rerun.

Validation

  • pytest -q tests/unit/test_release_workflow.py tests/unit/test_release_candidate.py tests/unit/test_release_gate.py (26 passed, 1 Windows symlink-permission skip)
  • ruff check tests/unit/test_release_workflow.py
  • ruff format --check tests/unit/test_release_workflow.py
  • actionlint 1.7.12, official archive SHA-256 verified
  • git diff --check

@DaoyuanLi2816
DaoyuanLi2816 merged commit 25ef67d into main Aug 30, 2026
16 checks passed
@DaoyuanLi2816
DaoyuanLi2816 deleted the v0.11.0-qualifier-venv-fix branch August 30, 2026 00:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

0