8000 Keep GPU qualification inside its virtualenv by DaoyuanLi2816 · Pull Request #101 · DaoyuanLi2816/mini-verl · GitHub
[go: up one dir, main page]
Skip to content

Keep GPU qualification inside its virtualenv #101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DaoyuanLi2816 merged 1 commit into from
Aug 30, 2026
Merged

Keep GPU qualification inside its virtualenv #101

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion .github/workflows/gpu.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,10 +117,13 @@ jobs:
from pathlib import Path
manifest = json.loads(Path("candidate/candidate-manifest.json").read_text())
wheel = (Path("candidate") / manifest["wheel"]["filename"]).resolve()
qualification_python = Path.cwd() / ".gpu-qualification-venv/bin/python"
if not qualification_python.is_file():
raise SystemExit(f"missing qualification interpreter: {qualification_python}")
with Path(os.environ["GITHUB_ENV"]).open("a", encoding="utf-8") as handle:
handle.write(f"QUALIFICATION_WHEEL={wheel}\n")
handle.write(f"QUALIFICATION_WHEEL_SHA256={manifest['wheel']['sha256']}\n")
handle.write(f"QUALIFICATION_PYTHON={Path('.gpu-qualification-venv/bin/python').resolve()}\n")
handle.write(f"QUALIFICATION_PYTHON={qualification_python}\n")
PY
- name: Install the exact candidate wheel
run: |
Expand Down
2 changes: 2 additions & 0 deletions tests/unit/test_release_workflow.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,6 +118,8 @@ def test_gpu_workflow_builds_candidate_only_on_hosted_job() -> None:
assert "runs-on: [self-hosted, cuda, rtx4080, wsl2]" in qualify
assert "shell: pwsh" not in qualify
assert 'uv" venv --seed --python 3.12.13' in qualify
assert 'Path.cwd() / ".gpu-qualification-venv/bin/python"' in qualify
assert "Path('.gpu-qualification-venv/bin/python').resolve()" not in qualify


def test_gpu_workflow_refuses_rerun_attempts_and_separates_smoke_from_full() -> None:
Expand Down
0