Repository navigation
fix(ci): retain verifiable history across rebased pushes - #197
Closed
dominicnunez wants to merge 1 commit into
Closed
dominicnunez wants to merge 1 commit into
dominicnunez wants to merge 1 commit into
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This was referenced Sep 12, 2026
dominicnunez
added a commit
that referenced
this pull request
Sep 12, 2026
Long writer validation could occupy the ledger's sole working connection long enough to prevent safety reads, cancelling otherwise healthy execution with `containment_unavailable`. This is a confirmed failure mechanism consistent with the two distinct-account routing failures blocking #197; the original CI scheduling failure was not independently reproduced. Authority observations now use a separate, single-connection pool against the same committed ledger. Writer admission remains transactional and serialized. The existing one-second watchdog, 250-ms poll deadline, 50-ms database wait, freeze history, and exact cancellation causes are preserved. Startup rejects connection-private database paths whose observer cannot see the migrated ledger; normal file storage and `:memory:` remain supported. Both pools are closed with the store, and the private-memory keeper remains independent. Regression coverage checks live observation, dispatch rechecks, and nested admission during writer validation; subsequent committed holds must still cancel with the exact hold cause. Existing unavailable-reader tests now occupy the observation connection. Real exclusive-lock tests remain intact, and forced observer disposal verifies private-memory authority survives. Validation: - The final regression fails on main for blocked dispatch authority reads in both memory and file storage. - New/updated focused cases passed three race repetitions; five distinct-account routing repetitions passed. - Full ledger, application, inference, and recovery race suites passed. The final startup-query cleanup also passed focused race regressions. - Build, vet, lint, architecture boundaries, and controlled-document validation passed. Closes #198.
dominicnunez
force-pushed
the
fix/ci-rebased-history
branch
from
September 12, 2026 11:47
837fc5c to
5995789
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rebasing and force-pushing a branch left push CI unable to resolve its previous head. Simply fetching that commit was insufficient: it could also cease to be an ancestor, which the history verifier correctly rejects.
Fetch the previous branch head through the pinned checkout action before checking out the assessed source, with credentials removed after each checkout. For existing branch pushes, resolve one common ancestor and verify every current commit after it. Rewinds still verify the target commit against its parent. Missing, unrelated, ambiguous, invalid, or root-only history fails explicitly. PRs retain the exact tested base; new-branch and tag selection remain unchanged. The committed-source and history verifier is unchanged.
Validation: 84 Python tests passed, covering real Git fast-forwards, rebases, unreachable previous heads, rewinds, and rejection paths alongside existing source/history safeguards. Actionlint passed. The exact PR #193 before/head pair resolved to its shared ancestor and produced two byte-identical verified assessment bundles.
Closes #196. Unblocks #193; the broader #178 acceptance work remains separate.