Repository navigation
fix(ledger): keep safety reads clear of writer waits - #199
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Long writer validation could occupy the ledger's sole working connection long enough to prevent safety reads, cancelling otherwise healthy execution with
containment_unavailable. This is a confirmed failure mechanism consistent with the two distinct-account routing failures blocking #197; the original CI scheduling failure was not independently reproduced.Authority observations now use a separate, single-connection pool against the same committed ledger. Writer admission remains transactional and serialized. The existing one-second watchdog, 250-ms poll deadline, 50-ms database wait, freeze history, and exact cancellation causes are preserved. Startup rejects connection-private database paths whose observer cannot see the migrated ledger; normal file storage and
:memory:remain supported. Both pools are closed with the store, and the private-memory keeper remains independent.Regression coverage checks live observation, dispatch rechecks, and nested admission during writer validation; subsequent committed holds must still cancel with the exact hold cause. Existing unavailable-reader tests now occupy the observation connection. Real exclusive-lock tests remain intact, and forced observer disposal verifies private-memory authority survives.
Validation:
Closes #198.