Repository navigation
refactor(sessions): drop dead session, runtime, and event paths - #197
Merged
Merged
Conversation
Deploying mikan with
|
| Latest commit: |
75e65f7
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://58c2be62.mikan-1wv.pages.dev |
| Branch Preview URL: | https://refactor-simplify-sessions.mikan-1wv.pages.dev |
geminixiang
marked this pull request as ready for review
October 26, 2026 10:20
Owner
Author
Behavior-preserving cleanup after the subagent tool's retirement (ADR 0028): - Remove the conversation owner walk (ownerOf, conversationOfProviderSession, ownedByContinuing, recordOwner, bindingOf, bindingOfProviderSession, the conversationCreated hook) and its test-only "delegate" tool test, restoring the pre-600556cc continuation and routing. Task sessions, the only other task-owned conversations, are in the session index and bind directly. - Route appendMessage, appendCustomEntry, and appendCompactionSummary through appendSessionEntry. - Remove the unused SessionStore.getContextEntries (and its mention in the four core-interfaces locales) and settle's never-passed markRunning option. - chat-history-sync: sortTime reuses parseMessageTimestamp; callers use SessionStore.exists instead of the hasMaterializedChatSession pass-through. - events: resolve the bot when an event is scheduled, so delivery has no unreachable missing-bot branch. - runtime: build the run attributes once; main.ts passes the provisioner as the resource controller and purges token stores in one interval.
geminixiang
force-pushed
the
refactor/simplify-sessions
branch
from
October 26, 2026 10:52
96cc4a2 to
75e65f7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stage 3 of
docs/research/simplify-modules-2026-10.md(#196). Behavior-preserving; 13 files, +125 / −338.ownerOf,conversationOfProviderSession,ownedByContinuing,recordOwner,bindingOf,bindingOfProviderSession,conversationCreated) and its "delegate" testappendMessage/appendCustomEntry/appendCompactionSummarygo throughappendSessionEntrySessionStore.getContextEntriesandSessionLifecycle.settle'smarkRunningmarkRunningwas added for dream)chat-history-sync:sortTimereusesparseMessageTimestamp; callers useSessionStore.existsdirectlyEventScheduler: resolve the bot once when scheduling; drop themissing_botbranchresolve()already rejects a missing bot andbotsByPlatformnever changesconversation-runtime: build run attributes once;main.ts: dropresourceController, one purge intervalDeferred: moving migration-only import code to
src/migrations/(needs an owner decision). Not done (behavior changes):getSessionMessageTextviacontentText, a shared event-payload validator.Verification
npm run typechecknpm testnpm run duplicationEval: existing tests, typecheck, and source guards serve as the before/after baseline, as agreed for behavior-preserving refactors.
Pending: this changes the session continuation path, so
slack-e2e.ymlmust pass before merge. Draft until then.Risk: an unfinished child conversation left by the old subagent tool is now aborted on restart instead of continued with its owner; it could not finish after the upgrade anyway.