Repository navigation
test(e2e): keep S-023's busy run in the conversation - #202
Merged
Merged
Conversation
Since channels offer start_task (#193), the model may hand the busy run to a background task. Its reply then lands in the task thread, outside the thread S-023 polls, and the channel is never busy, so the case no longer tests queueing. Two of four runs on 2026-10-26 failed this way; both used start_task.
This was referenced Oct 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
S-023 checks that a message sent while mikan is busy is queued and answered. Since #193 offers
start_taskin channels, the model may admit the busy request as a background task. The task's reply then goes to the task thread, which S-023 does not poll, and the channel is never busy, so the case stops testing queueing.Evidence from four Slack E2E runs on 2026-10-26 (the simplification PRs #197, #198, #200, #201):
start_taskusedThe daemon log shows intake, the task admission, and the token reply for both failures, so delivery was correct.
Change: the busy prompt asks the model to run
sleep 10in this conversation, not as a background task. Test-only, so done when CI and a Slack E2E run on this branch pass.