Repository navigation
refactor(sandbox,settings): drop dead options; one inspect for drift state - #200
Merged
Merged
Conversation
geminixiang
marked this pull request as ready for review
October 26, 2026 10:24
Owner
Author
…y linkAbortSignal and VaultManager.list ProvisionOptions.containerName had one caller, which passed the default name, so the resolver's returned-name check could never fail.
…iters noPlatformsMessage now reuses envSummaryLines.
…pdate diagnostics caller
provision read status, binds, and each label with separate inspect calls (up to five per run). One template returns them all, so a steady-state provision costs one inspect instead of four, and a stopped one one instead of five. The fake engine now evaluates templates field by field.
geminixiang
force-pushed
the
refactor/simplify-sandbox-settings
branch
from
October 26, 2026 10:58
5f23f00 to
49d09f5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stage 4 of
docs/research/simplify-modules-2026-10.md(#196). 17 files, +159 / −265.ProvisionOptions.containerName,ContainerState.containerName,getContainerName, and the resolver's actual-vs-expected checklinkAbortSignal,VaultManager.list()(andRESERVED_VAULT_DIRS, then unused)rewriteSettingsFilefor the three settings writers;noPlatformsMessagereusesenvSummaryLinesrecordDiagnosticEventtakes aDiagnosticBreadcrumb; Slack names move toupdate-diagnostics.ts"diagnostic"default was unreachableinspecttemplateInspect calls per provision, measured against real Docker with a scratch driver (6/6 cases pass on main and branch):
Verification
npm run typechecknpm testnpm run duplicationPending: the combined inspect template is verified on Docker only; run it on nerdctl and Podman before merge. Sandbox provisioning is on the run path, so
slack-e2e.ymltoo. Draft until then.