Repository navigation
Ensure consent is granted before token-exchange - #26908
Closed
cavuugroup wants to merge 4 commits into
Closed
cavuugroup wants to merge 4 commits into
cavuugroup wants to merge 4 commits into
Conversation
pedroigor
requested changes
Feb 8, 2024
cavuugroup
force-pushed
the
issue/KC/20702
branch
from
February 15, 2024 17:35
fc25532 to
2c8ba72
Compare
Closes keycloak#20702 Signed-off-by: Krzysztof Walczewski <kwalczewski@gmail.com>
cavuugroup
force-pushed
the
issue/KC/20702
branch
from
February 20, 2024 09:03
2c8ba72 to
e106988
Compare
Contributor
|
@cavuugroup thanks for your contribution! Would you mind changing the title of this PR to: |
Member
|
@thomasdarimont - I helped out here a bit by changing it as I have write permissions on it. I also see there is a conflict for this PR which needs to be resolved before it can be merged. |
This was referenced Jun 28, 2024
Member
|
@pedroigor / @thomasdarimont - The build is green, and the conflicts are gone. Are those changes good to be merged? |
|
Any chance of this being merged? |
Contributor
|
Since this is for the now deprecated token exchange v1, this should probably be closed. @mposolda wdyt? |
Contributor
|
Closing as this is for token-exchange V1. The Token-exchange:v2 should work in a way proposed in a PR and in the GH issue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #20702
Verification of user consents to scopes requested by the target client during client to client token exchange.