8000 Verification of user consents to scopes requested by the target clien… by cavuugroup · Pull Request #26514 · keycloak/keycloak · GitHub
[go: up one dir, main page]

Skip to content

Verification of user consents to scopes requested by the target clien… - #26514

Closed
cavuugroup wants to merge 103 commits into
keycloak:mainfrom
cavuugroup:issue/20702
Closed

cavuugroup wants to merge 103 commits into
keycloak:mainfrom
cavuugroup:issue/20702

Conversation

@cavuugroup
Copy link
Copy Markdown

…t during client to client token exchange

Closes #20702

@cavuugroup
cavuugroup requested review from a team as code owners January 25, 2024 17:18
@cavuugroup
cavuugroup requested a review from a team January 25, 2024 17:18
@cavuugroup
cavuugroup requested a review from a team as a code owner January 25, 2024 17:18
@cavuugroup
cavuugroup force-pushed the issue/20702 branch 4 times, most recently from e4d05b6 to d90a85c Compare February 1, 2024 09:55
@cavuugroup
cavuugroup requested review from a team as code owners February 7, 2024 11:18
@pedroigor
Copy link
Copy Markdown
Contributor

@cavuugroup Would you mind signing off your commit?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it really passing over the requested client scopes? Looks like you are only passing the const OAuth2Constants.SCOPE to TokenManager.getRequestedClientScopes?

The requested scopes are available from the following lines.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are right. I pushed out commit with fix.

stianst and others added 4 commits February 8, 2024 11:57
Signed-off-by: Krzysztof Walczewski <kwalczewski@gmail.com>
…t during client to client token exchange

Closes keycloak#20702

Signed-off-by: Krzysztof Walczewski <kwalczewski@gmail.com>
* renamed messages

Signed-off-by: Agnieszka Gancarczyk <agancarc@redhat.com>

* fixed test

Signed-off-by: Agnieszka Gancarczyk <agancarc@redhat.com>

---------

Signed-off-by: Agnieszka Gancarczyk <agancarc@redhat.com>
Co-authored-by: Agnieszka Gancarczyk <agancarc@redhat.com>
Signed-off-by: Krzysztof Walczewski <kwalczewski@gmail.com>
Closes keycloak#26320

Signed-off-by: Pedro Igor <pigor.craveiro@gmail.com>
Signed-off-by: Krzysztof Walczewski <kwalczewski@gmail.com>
dependabot Bot and others added 22 commits February 8, 2024 11:57
Bumps [react-hook-form](https://github.com/react-hook-form/react-hook-form) from 7.50.0 to 7.50.1.
- [Release notes](https://github.com/react-hook-form/react-hook-form/releases)
- [Changelog](https://github.com/react-hook-form/react-hook-form/blob/master/CHANGELOG.md)
- [Commits](react-hook-form/react-hook-form@v7.50.0...v7.50.1)

---
updated-dependencies:
- dependency-name: react-hook-form
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: Krzysztof Walczewski <kwalczewski@gmail.com>
…cloak#26840)

Signed-off-by: gitdallas <5322142+gitdallas@users.noreply.github.com>
Signed-off-by: Krzysztof Walczewski <kwalczewski@gmail.com>
Bumps [react-i18next](https://github.com/i18next/react-i18next) from 14.0.3 to 14.0.5.
- [Changelog](https://github.com/i18next/react-i18next/blob/master/CHANGELOG.md)
- [Commits](i18next/react-i18next@v14.0.3...v14.0.5)

---
updated-dependencies:
- dependency-name: react-i18next
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: Krzysztof Walczewski <kwalczewski@gmail.com>
* fixed refresh btn for events

Signed-off-by: Agnieszka Gancarczyk <agancarc@redhat.com>

* cleanup

Signed-off-by: Agnieszka Gancarczyk <agancarc@redhat.com>

---------

Signed-off-by: Agnieszka Gancarczyk <agancarc@redhat.com>
Co-authored-by: Agnieszka Gancarczyk <agancarc@redhat.com>
Signed-off-by: Krzysztof Walczewski <kwalczewski@gmail.com>
Closes keycloak#26847

Signed-off-by: stianst <stianst@gmail.com>
Signed-off-by: Krzysztof Walczewski <kwalczewski@gmail.com>
Add a mention about beans.xml and @Provider in the extending server documentation

Add beans.xml in the rest provider example

Add a mention about @Provider in the upgrading guides

Closes keycloak#25882

Signed-off-by: zak905 <zakaria.amine88@gmail.com>

Address suggested change for docs/documentation/server_development/topics/extensions.adoc

Co-authored-by: Pedro Igor <pigor.craveiro@gmail.com>

Address suggested change for docs/documentation/server_development/topics/extensions.adoc

Co-authored-by: Pedro Igor <pigor.craveiro@gmail.com>
Signed-off-by: zak905 <zakaria.amine88@gmail.com>

Address suggested change for docs/documentation/upgrading/topics/keycloak/changes-22_0_0.adoc

Co-authored-by: Pedro Igor <pigor.craveiro@gmail.com>
Signed-off-by: zak905 <zakaria.amine88@gmail.com>
Signed-off-by: Krzysztof Walczewski <kwalczewski@gmail.com>
Co-authored-by: andymunro <48995441+andymunro@users.noreply.github.com>
Signed-off-by: zak905 <zakaria.amine88@gmail.com>
Signed-off-by: Krzysztof Walczewski <kwalczewski@gmail.com>
Signed-off-by: zak905 <zakaria.amine88@gmail.com>
Signed-off-by: Krzysztof Walczewski <kwalczewski@gmail.com>
…#26630)

This change adds event for brute force protector when user account is
temporarily disabled.

It also lowers the priority of free-text log for failed login attempts.

Signed-off-by: Tero Saarni <tero.saarni@est.tech>
Signed-off-by: Alexander Schwartz <aschwart@redhat.com>
Co-authored-by: Alexander Schwartz <aschwart@redhat.com>
Signed-off-by: Krzysztof Walczewski <kwalczewski@gmail.com>
…loak#26834)

The former version stated that the "Reset OTP" step had to be disabled in the "reset credentials" authentication flow in order to keep the OTP unchanged. This leads to an error. More precisely, the "Reset - Conditional OTP" sub-flow has to be disabled.

Fixex keycloak#26834

Signed-off-by: Michael Schnitzler <schnitzler.michael+github@gmail.com>
Signed-off-by: Krzysztof Walczewski <kwalczewski@gmail.com>
Signed-off-by: Steve Hawkins <shawkins@redhat.com>
Signed-off-by: Krzysztof Walczewski <kwalczewski@gmail.com>
Closes keycloak#26781

Signed-off-by: Alexander Schwartz <aschwart@redhat.com>
Signed-off-by: Krzysztof Walczewski <kwalczewski@gmail.com>
closes keycloak#26823

Signed-off-by: Steve Hawkins <shawkins@redhat.com>
Signed-off-by: Krzysztof Walczewski <kwalczewski@gmail.com>
Co-authored-by: Václav Muzikář <vaclav@muzikari.cz>
Signed-off-by: Krzysztof Walczewski <kwalczewski@gmail.com>
…keycloak#26788)

* elevating wildfly-elytron-http-oidc version management

Signed-off-by: Steve Hawkins <shawkins@redhat.com>

* removing testing dependency overrides

Signed-off-by: Steve Hawkins <shawkins@redhat.com>

* further version aligment with quarkus

Signed-off-by: Steve Hawkins <shawkins@redhat.com>

* adding a resteay-core-spi that can be overriden

Signed-off-by: Steve Hawkins <shawkins@redhat.com>

* removing hamcrest override

Signed-off-by: Steve Hawkins <shawkins@redhat.com>

* aligning with 3.7.1

Signed-off-by: Steve Hawkins <shawkins@redhat.com>

---------

Signed-off-by: Steve Hawkins <shawkins@redhat.com>
Signed-off-by: Krzysztof Walczewski <kwalczewski@gmail.com>
…client

Closes keycloak#21409

Signed-off-by: Douglas Palmer <dpalmer@redhat.com>
Signed-off-by: Krzysztof Walczewski <kwalczewski@gmail.com>
Signed-off-by: Douglas Palmer <dpalmer@redhat.com>
Signed-off-by: Krzysztof Walczewski <kwalczewski@gmail.com>
… themes (keycloak#26858)

Closes keycloak#26856

Signed-off-by: stianst <stianst@gmail.com>
Signed-off-by: Krzysztof Walczewski <kwalczewski@gmail.com>
Bumps [@types/react-dom](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/react-dom) from 18.2.18 to 18.2.19.
- [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases)
- [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/react-dom)

---
updated-dependencies:
- dependency-name: "@types/react-dom"
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: Krzysztof Walczewski <kwalczewski@gmail.com>
Closes keycloak#20702

Signed-off-by: Krzysztof Walczewski <kwalczewski@gmail.com>
Closes keycloak#26051
Signed-off-by: Michal Hajas <mhajas@redhat.com>
Co-authored-by: Hynek Mlnařík <hmlnarik@users.noreply.github.com>
Signed-off-by: Krzysztof Walczewski <kwalczewski@gmail.com>
…k#26838)

closes keycloak#26826

Signed-off-by: Dominik Topp <19268966+dominiktopp@users.noreply.github.com>
Signed-off-by: Krzysztof Walczewski <kwalczewski@gmail.com>
@jonkoops
jonkoops commented Feb 8, 2024
Copy link
Copy Markdown
Contributor

Closing this PR, as it has become conflicted and contains a bunch of unrelated commits. Feel free to open up a new one with a clean branch.

@jonkoops jonkoops closed this Feb 8, 2024
@cavuugroup
cavuugroup commented Feb 8, 2024 •
Copy link
Copy Markdown
Author

@jonkoops @pedroigor #26908

@cavuugroup
cavuugroup deleted the issue/20702 branch February 8, 2024 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Token Exchange should allow exchange for clients that require consent if user has given consent for requested scopes
0