8000 Update messages_de.properties by ch-lepp · Pull Request #28962 · keycloak/keycloak · GitHub
[go: up one dir, main page]
Skip to content

Update messages_de.properties - #28962

Merged
jonkoops merged 7 commits into
keycloak:mainfrom
ch-lepp:master
Apr 24, 2024
Merged

Update messages_de.properties#28962
jonkoops merged 7 commits into
keycloak:mainfrom
ch-lepp:master

Conversation

@ch-lepp
@ch-lepp ch-lepp commented Apr 22, 2024
Copy link
Copy Markdown
Contributor

Added missing German translations

@ch-lepp
ch-lepp requested review from a team as code owners April 22, 2024 09:22
This was referenced Apr 22, 2024
Closed
Closed
@jonkoops
jonkoops commented Apr 22, 2024
Copy link
Copy Markdown
Contributor

Could you sign off on your commit?

@ch-lepp
ch-lepp commented Apr 22, 2024 •
edited
Loading
Copy link
Copy Markdown
Contributor Author

Done, I think...

Or maybe not - the check is still failing...

@edewit
edewit commented Apr 22, 2024
Copy link
Copy Markdown
Contributor

@ch-lepp you can do a git rebase upstream/main --signoff

@ch-lepp
ch-lepp commented Apr 22, 2024
Copy link
Copy Markdown
Contributor Author

Ok, I think I've got it now.

Thx

@jonkoops
jonkoops commented Apr 22, 2024
Copy link
Copy Markdown
Contributor

@ch-lepp if you can get another German native speaker to review your work we can merge this in.

@jonkoops
jonkoops enabled auto-merge (squash) April 22, 2024 10:32
@jonkoops
jonkoops commented Apr 22, 2024
Copy link
Copy Markdown
Contributor

Don't worry about the CI failures, we're working on a fix for it.
Persi
Persi suggested changes Apr 22, 2024
View reviewed changes
@Persi Persi left a comment
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've commented some suggestions.

Comment thread themes/src/main/resources-community/theme/base/login/messages/messages_de.properties Resolved
Comment thread themes/src/main/resources-community/theme/base/login/messages/messages_de.properties Resolved
Comment thread themes/src/main/resources-community/theme/base/login/messages/messages_de.properties Resolved
Comment thread themes/src/main/resources-community/theme/base/login/messages/messages_de.properties Resolved
Comment thread themes/src/main/resources-community/theme/base/login/messages/messages_de.properties Resolved
Comment thread themes/src/main/resources-community/theme/base/login/messages/messages_de.properties Resolved
Comment thread themes/src/main/resources-community/theme/base/login/messages/messages_de.properties Resolved
Comment thread themes/src/main/resources-community/theme/base/login/messages/messages_de.properties Resolved
auto-merge was automatically disabled April 22, 2024 11:18

Head branch was pushed to by a user without write access

@ch-lepp
ch-lepp commented Apr 22, 2024
Copy link
Copy Markdown
Contributor Author

I applied the review suggestions

Persi
Persi approved these changes Apr 22, 2024
View reviewed changes
@Persi Persi left a comment
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jonkoops
jonkoops enabled auto-merge (squash) April 22, 2024 15:32
@jonkoops
jonkoops commented Apr 22, 2024
Copy link
Copy Markdown
Contributor

Thanks all, I will set the PR to merge.

@jonkoops
jonkoops commented Apr 23, 2024
Copy link
Copy Markdown
Contributor

Please refrain from merging things in from main unless absolutely necessary, as this causes CI to re-trigger and creates additional work for us.

This was referenced Apr 23, 2024
Closed
Closed
Closed
Closed
Closed
Closed
This was referenced Apr 23, 2024
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
ch-lepp and others added 7 commits April 24, 2024 06:49
@ch-lepp @ahus1
Update messages_de.properties
7ae1f9a 
Added missing German translations

Signed-off-by: Leppelt Christian <cleppelt@nlberlin.deg.local>
@ch-lepp @ahus1
Update messages_de.properties
c197b1d 
Grammatik korrigiert

Signed-off-by: Leppelt Christian <cleppelt@nlberlin.deg.local>
@ch-lepp @ahus1
Update messages_de.properties
314c483 
Refactoring

Signed-off-by: Leppelt Christian <cleppelt@nlberlin.deg.local>
Leppelt Christian @ahus1
fix: reverted broken commits
8543840 
Signed-off-by: Leppelt Christian <cleppelt@nlberlin.deg.local>
Leppelt Christian @ahus1
fix: added missing German translations
23de9f3 
Signed-off-by: Leppelt Christian <cleppelt@nlberlin.deg.local>
Leppelt Christian @ahus1
fix: applied code review comments
f6a15c6 
Signed-off-by: Leppelt Christian <cleppelt@nlberlin.deg.local>
@ahus1
Fix duplicate message key after rebase
d163421 
Signed-off-by: Alexander Schwartz <aschwart@redhat.com>
@ahus1 ahus1 self-assigned this Apr 24, 2024
keycloak-github-bot[bot]
keycloak-github-bot Bot reviewed Apr 24, 2024
View reviewed changes
@keycloak-github-bot keycloak-github-bot Bot left a comment
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unreported flaky test detected, please review

@keycloak-github-bot
keycloak-github-bot Bot commented Apr 24, 2024
Copy link
Copy Markdown

Unreported flaky test detected

If the flaky tests below are affected by the changes, please review and update the changes accordingly. Otherwise, a maintainer should report the flaky tests prior to merging the PR.

org.keycloak.testsuite.admin.concurrency.ConcurrencyTest#testAllConcurrently

Keycloak CI - Base IT (1)

java.lang.RuntimeException: There were failures in threads. Failures count: 1
	at org.keycloak.testsuite.admin.concurrency.AbstractConcurrencyTest.run(AbstractConcurrencyTest.java:122)
	at org.keycloak.testsuite.admin.concurrency.AbstractConcurrencyTest.run(AbstractConcurrencyTest.java:63)
	at org.keycloak.testsuite.admin.concurrency.AbstractConcurrencyTest.run(AbstractConcurrencyTest.java:59)
	at org.keycloak.testsuite.admin.concurrency.ConcurrencyTest.concurrentTest(ConcurrencyTest.java:61)
...

Report flaky test

@jonkoops
jonkoops merged commit adca2c6 into keycloak:main Apr 24, 2024
keycloak-github-bot[bot]
keycloak-github-bot Bot reviewed Apr 24, 2024
View reviewed changes
@keycloak-github-bot keycloak-github-bot Bot left a comment
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unreported flaky test detected, please review

@keycloak-github-bot
keycloak-github-bot Bot commented Apr 24, 2024
Copy link
Copy Markdown

Unreported flaky test detected

If the flaky tests below are affected by the changes, please review and update the changes accordingly. Otherwise, a maintainer should report the flaky tests prior to merging the PR.

org.keycloak.testsuite.admin.concurrency.ConcurrencyTest#testAllConcurrently

Keycloak CI - Base IT (1)

java.lang.RuntimeException: There were failures in threads. Failures count: 1
	at org.keycloak.testsuite.admin.concurrency.AbstractConcurrencyTest.run(AbstractConcurrencyTest.java:122)
	at org.keycloak.testsuite.admin.concurrency.AbstractConcurrencyTest.run(AbstractConcurrencyTest.java:63)
	at org.keycloak.testsuite.admin.concurrency.AbstractConcurrencyTest.run(AbstractConcurrencyTest.java:59)
	at org.keycloak.testsuite.admin.concurrency.ConcurrencyTest.concurrentTest(ConcurrencyTest.java:61)
...

Report flaky test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ahus1 ahus1 ahus1 approved these changes
+2 more reviewers
@keycloak-github-bot keycloak-github-bot[bot] keycloak-github-bot[bot] left review comments
@Persi Persi Persi approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@ahus1 ahus1

Labels

flaky-test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@ch-lepp @jonkoops @edewit @Persi @ahus1
0