8000 keep query parameters when changing routes by edewit · Pull Request #32762 · keycloak/keycloak · GitHub
[go: up one dir, main page]
Skip to content

keep query parameters when changing routes - #32762

Merged
edewit merged 1 commit into
keycloak:mainfrom
edewit:issue-32736
Sep 10, 2024
Merged

keep query parameters when changing routes#32762
edewit merged 1 commit into
keycloak:mainfrom
edewit:issue-32736

Conversation

@edewit
@edewit edewit commented Sep 10, 2024
Copy link
Copy Markdown
Contributor

fixes: #32736
Signed-off-by: Erik Jan de Wit erikjan.dewit@gmail.com

@edewit
edewit requested a review from a team as a code owner September 10, 2024 09:34
@edewit edewit self-assigned this Sep 10, 2024
@keycloak-github-bot keycloak-github-bot Bot mentioned this pull request Sep 10, 2024
Closed
@keycloak-github-bot
keycloak-github-bot Bot commented Sep 10, 2024
Copy link
Copy Markdown

Unreported flaky test detected

If the flaky tests below are affected by the changes, please review and update the changes accordingly. Otherwise, a maintainer should report the flaky tests prior to merging the PR.

org.keycloak.testsuite.webauthn.registration.passwordless.PwdLessUserVerRegTest#preferredNoVerification

Keycloak CI - WebAuthn IT (chrome)

java.lang.AssertionError: Expected RegisterPage but was Sign in to test (https://localhost:8543/auth/realms/test/protocol/openid-connect/auth?response_type=code&client_id=test-app&redirect_uri=https%3A%2F%2Flocalhost%3A8543%2Fauth%2Frealms%2Fmaster%2Fapp%2Fauth&state=6bd7fe73-f070-4bf9-94be-b32187d71ec6&scope=openid)
	at org.junit.Assert.fail(Assert.java:89)
	at org.junit.Assert.assertTrue(Assert.java:42)
	at org.keycloak.testsuite.pages.AbstractPage.assertCurrent(AbstractPage.java:47)
	at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103)
...

Report flaky test

org.keycloak.testsuite.forms.LoginTest#loginWithEmailUserAndRememberMe

Keycloak CI - Forms IT (chrome)

java.lang.AssertionError
	at org.junit.Assert.fail(Assert.java:87)
	at org.junit.Assert.assertTrue(Assert.java:42)
	at org.junit.Assert.assertTrue(Assert.java:53)
	at org.keycloak.testsuite.forms.LoginTest.loginWithEmailUserAndRememberMe(LoginTest.java:740)
...

Report flaky test

keycloak-github-bot[bot]
keycloak-github-bot Bot reviewed Sep 10, 2024
View reviewed changes
@keycloak-github-bot keycloak-github-bot Bot left a comment
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unreported flaky test detected, please review

@edewit
keep query parameters when changing routes
5aeafb4 
fixes: keycloak#32736
Signed-off-by: Erik Jan de Wit <erikjan.dewit@gmail.com>
This was referenced Sep 10, 2024
Closed
Closed
Closed
@keycloak-github-bot
keycloak-github-bot Bot commented Sep 10, 2024
Copy link
Copy Markdown

Unreported flaky test detected

If the flaky tests below are affected by the changes, please review and update the changes accordingly. Otherwise, a maintainer should report the flaky tests prior to merging the PR.

org.keycloak.testsuite.webauthn.registration.PubKeySignRegisterTest#publicKeySignaturesWrong

Keycloak CI - WebAuthn IT (chrome)

java.lang.AssertionError: Expected RegisterPage but was Sign in to test (https://localhost:8543/auth/realms/test/protocol/openid-connect/auth?response_type=code&client_id=test-app&redirect_uri=https%3A%2F%2Flocalhost%3A8543%2Fauth%2Frealms%2Fmaster%2Fapp%2Fauth&state=52fee1f4-238b-4be8-9d4d-416a342e7708&scope=openid)
	at org.junit.Assert.fail(Assert.java:89)
	at org.junit.Assert.assertTrue(Assert.java:42)
	at org.keycloak.testsuite.pages.AbstractPage.assertCurrent(AbstractPage.java:47)
	at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103)
...

Report flaky test

@keycloak-github-bot keycloak-github-bot Bot mentioned this pull request Sep 10, 2024
Closed
keycloak-github-bot[bot]
keycloak-github-bot Bot reviewed Sep 10, 2024
View reviewed changes
@keycloak-github-bot keycloak-github-bot Bot left a comment
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unreported flaky test detected, please review

@edewit
edewit merged commit d26a514 into keycloak:main Sep 10, 2024
@edewit edewit mentioned this pull request Sep 12, 2024
Merged
edewit added a commit to edewit/keycloak that referenced this pull request Sep 27, 2024
@edewit
keep query parameters when changing routes (keycloak#32762)
89da7e9 
fixes: keycloak#32736

Signed-off-by: Erik Jan de Wit <erikjan.dewit@gmail.com>
(cherry picked from commit d26a514)
jonkoops pushed a commit that referenced this pull request Sep 27, 2024
@edewit
keep query parameters when changing routes (#32762) (#32856)
c36eb8a 
Closes #32736

Signed-off-by: Erik Jan de Wit <erikjan.dewit@gmail.com>
(cherry picked from commit d26a514)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ssilvert ssilvert ssilvert approved these changes
+1 more reviewer
@keycloak-github-bot keycloak-github-bot[bot] keycloak-github-bot[bot] left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

@edewit edewit

Labels

flaky-test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

In the account console when I update the password the referrer dissapears

2 participants

@edewit @ssilvert
0