8000 BACKPORT: keep query parameters when changing routes (#32762) by edewit · Pull Request #32856 · keycloak/keycloak · GitHub
[go: up one dir, main page]
Skip to content

BACKPORT: keep query parameters when changing routes (#32762) - #32856

Merged
jonkoops merged 1 commit into
keycloak:release/25.0from
edewit:backport-32762-25.0
Sep 27, 2024
Merged

BACKPORT: keep query parameters when changing routes (#32762)#32856
jonkoops merged 1 commit into
keycloak:release/25.0from
edewit:backport-32762-25.0

Conversation

@edewit
@edewit edewit commented Sep 12, 2024 •
edited by jonkoops
Loading
Copy link
Copy Markdown
Contributor

backport: #32762
Closes #32736

Signed-off-by: Erik Jan de Wit erikjan.dewit@gmail.com
(cherry picked from commit d26a514)

@edewit
edewit requested a review from a team as a code owner September 12, 2024 12:22
@keycloak-github-bot keycloak-github-bot Bot mentioned this pull request Sep 12, 2024
Closed
@cgm-maarten
cgm-maarten commented Sep 23, 2024
Copy link
Copy Markdown

Is there anything I can do to speed this up?

It seems to hang on the following job

Job status:

  • jdk-integration-tests: failure

But I fail to see how this is related to the frontend.

Is it just as simpel as rerunning the build?

@jonkoops
jonkoops enabled auto-merge (squash) September 23, 2024 09:36
@keycloak-github-bot keycloak-github-bot Bot mentioned this pull request Sep 23, 2024
Closed
@edewit
edewit force-pushed the backport-32762-25.0 branch from 886ea03 to a91ec02 Compare September 24, 2024 09:01
@edewit
keep query parameters when changing routes (keycloak#32762)
89da7e9 
fixes: keycloak#32736

Signed-off-by: Erik Jan de Wit <erikjan.dewit@gmail.com>
(cherry picked from commit d26a514)
@edewit
edewit force-pushed the backport-32762-25.0 branch from a91ec02 to 89da7e9 Compare September 27, 2024 11:22
@cgm-maarten
cgm-maarten commented Sep 27, 2024
Copy link
Copy Markdown

BaseIT

--------- org.keycloak.testsuite.oauth.TokenIntrospectionTest output end  ---------
Error:  Tests run: 23, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 7.435 s <<< FAILURE! - in org.keycloak.testsuite.oauth.TokenIntrospectionTest
Error: OR] org.keycloak.testsuite.oauth.TokenIntrospectionTest.testUnsupportedToken  Time elapsed: 0.113 s  <<< ERROR!

Doesn't seem related.

Java Distribution IT temurin 17 (independent of windows/ubuntu)
Build with JDK:

Error: Failed to execute goal com.github.eirslett:frontend-maven-plugin:1.15.0:install-node-and-pnpm (default) on project keycloak-js-adapter-jar: Could not download Node.js: Could not download https://nodejs.org/dist/v20.13.0/node-v20.13.0-linux-x64.tar.gz: Premature end of Content-Length delimited message body (expected: 46,650,985; received: 843,776) -> [Help 1]
Download problem from nodejs.

Error:  
Error:  Re-run Maven using the -X switch to enable full debug logging.
Error:  
Error:  For more information about the errors and possible solutions, please read the following articles:
Error:  [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException
Error:  
Error:  After correcting the problems, you can resume the build with the command
Error:    mvn <args> -rf :keycloak-js-adapter-jar
Error: Process completed with exit code 1.

@jonkoops
jonkoops merged commit c36eb8a into keycloak:release/25.0 Sep 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@jonkoops jonkoops jonkoops approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@edewit edewit

Labels

flaky-test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@edewit @cgm-maarten @jonkoops
0