Repository navigation
Conversation
Fixes keycloak#32916 Signed-off-by: Stan Silvert <ssilvert@redhat.com>
Unreported flaky test detectedIf the flaky tests below are affected by the changes, please review and update the changes accordingly. Otherwise, a maintainer should report the flaky tests prior to merging the PR. org.keycloak.testsuite.webauthn.WebAuthnTransportsTest#usbTransportKeycloak CI - WebAuthn IT (chrome) |
edewit
requested changes
Sep 16, 2024
Comment on lines
+90
to
+97
| const removeSpecialChars = (clientName: string): string => { | ||
| if (clientName.startsWith("${") && clientName.endsWith("}")) { | ||
| return clientName.substring(2, clientName.length - 1); | ||
| } | ||
|
|
||
| return clientName; | ||
| }; | ||
|
|
Contributor
There was a problem hiding this comment.
There is already logic that does this and also looks up the name in the bundle
Suggested change
| const removeSpecialChars = (clientName: string): string => { | |
| if (clientName.startsWith("${") && clientName.endsWith("}")) { | |
| return clientName.substring(2, clientName.length - 1); | |
| } | |
| return clientName; | |
| }; |
import { label } from "@keycloak/keycloak-ui-shared";| let clientName: string; | ||
| if (client.clientName !== "") { | ||
| clientName = t(client.clientName as TFuncKey); | ||
| clientName = t(removeSpecialChars(client.clientName) as TFuncKey); |
Contributor
There was a problem hiding this comment.
Suggested change
| clientName = t(removeSpecialChars(client.clientName) as TFuncKey); | |
| clientName = label(t, client.clientName); |
Contributor
Author
|
Closed in favor of #32982 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #32916