8000 l18n for client names in device activity by ssilvert · Pull Request #32982 · keycloak/keycloak · GitHub
[go: up one dir, main page]
Skip to content

l18n for client names in device activity - #32982

Merged
ssilvert merged 1 commit into
keycloak:mainfrom
ssilvert:issue-32916-dev-activity-client-name-2
Sep 17, 2024
Merged

l18n for client names in device activity#32982
ssilvert merged 1 commit into
keycloak:mainfrom
ssilvert:issue-32916-dev-activity-client-name-2

Conversation

@ssilvert
@ssilvert ssilvert commented Sep 16, 2024
Copy link
Copy Markdown
Contributor

Fixes #32916

@ssilvert
l18n for client names in device activity
840e4d7 
Fixes
10000
 keycloak#32916

Signed-off-by: Stan Silvert <ssilvert@redhat.com>
@ssilvert
ssilvert requested a review from a team as a code owner September 16, 2024 12:20
@ssilvert ssilvert mentioned this pull request Sep 16, 2024
Closed
@ssilvert
ssilvert requested a review from edewit September 16, 2024 12:21
This was referenced Sep 16, 2024
Closed
Closed
Closed
Closed
keycloak-github-bot[bot]
keycloak-github-bot Bot reviewed Sep 16, 2024
View reviewed changes
@keycloak-github-bot keycloak-github-bot Bot left a comment
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unreported flaky test detected, please review

@keycloak-github-bot
keycloak-github-bot Bot commented Sep 16, 2024
Copy link
Copy Markdown

Unreported flaky test detected

If the flaky tests below are affected by the changes, please review and update the changes accordingly. Otherwise, a maintainer should report the flaky tests prior to merging the PR.

org.keycloak.testsuite.webauthn.registration.passwordless.PwdLessOtherSettingsTest#excludeCredentials

Keycloak CI - WebAuthn IT (chrome)

java.lang.AssertionError: Expected RegisterPage but was Sign in to test (https://localhost:8543/auth/realms/test/protocol/openid-connect/auth?response_type=code&client_id=test-app&redirect_uri=https%3A%2F%2Flocalhost%3A8543%2Fauth%2Frealms%2Fmaster%2Fapp%2Fauth&state=49328f3a-b208-4235-948b-bbf5690216a4&scope=openid)
	at org.junit.Assert.fail(Assert.java:89)
	at org.junit.Assert.assertTrue(Assert.java:42)
	at org.keycloak.testsuite.pages.AbstractPage.assertCurrent(AbstractPage.java:47)
	at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103)
...

Report flaky test

org.keycloak.testsuite.webauthn.registration.passwordless.PwdLessResidentKeyRegTest#residentKeyNotRequiredNoRK

Keycloak CI - WebAuthn IT (chrome)

java.lang.AssertionError: Expected LoginPage but was AUTH_RESPONSE (https://localhost:8543/auth/realms/master/app/auth?state=0668095b-f183-476e-a8c0-6fe60da1dce7&session_state=0529dc08-f0c6-409a-bc99-2b2fd08c8ebf&iss=https%3A%2F%2Flocalhost%3A8543%2Fauth%2Frealms%2Ftest&code=53e1efa3-83f3-4b7f-9766-f50df5bf7794.0529dc08-f0c6-409a-bc99-2b2fd08c8ebf.43ece0d9-cca5-46cc-90be-bb97bd6315f8)
	at org.junit.Assert.fail(Assert.java:89)
	at org.junit.Assert.assertTrue(Assert.java:42)
	at org.keycloak.testsuite.pages.AbstractPage.assertCurrent(AbstractPage.java:47)
	at org.keycloak.testsuite.pages.LoginPage.open(LoginPage.java:262)
...

Report flaky test

@ssilvert
ssilvert merged commit 01601be into keycloak:main Sep 17, 2024
ssilvert added a commit to ssilvert/keycloak that referenced this pull request Oct 3, 2024
@ssilvert
BACKPORT: l18n for client names in device activity (keycloak#32982)
cd706da 
Fixes keycloak#32916

Signed-off-by: Stan Silvert <ssilvert@redhat.com>
(cherry picked from commit 01601be)
jonkoops pushed a commit that referenced this pull request Oct 3, 2024
@ssilvert
BACKPORT: l18n for client names in device activity (#32982) (#33543)
1517914 
Fixes #32916

Signed-off-by: Stan Silvert <ssilvert@redhat.com>
(cherry picked from commit 01601be)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@edewit edewit edewit approved these changes
+1 more reviewer
@keycloak-github-bot keycloak-github-bot[bot] keycloak-github-bot[bot] left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

flaky-test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Device activity client name translations

2 participants

@ssilvert @edewit
0