8000 Update with core authn team by abstractj · Pull Request #47780 · keycloak/keycloak · GitHub
[go: up one dir, main page]

Skip to content

Update with core authn team - #47780

Merged
ahus1 merged 2 commits into
keycloak:mainfrom
abstractj:update-teams
Apr 13, 2026
Merged

ahus1 merged 2 commits into
keycloak:mainfrom
abstractj:update-teams

Conversation

@abstractj
Copy link
Copy Markdown
Contributor

No description provided.

@abstractj
abstractj requested review from rmartinc and stianst April 6, 2026 15:16
@abstractj
abstractj requested a review from a team as a code owner April 6, 2026 15:16
10BC8
Signed-off-by: Bruno Oliveira da Silva <bruno@abstractj.com>
@abstractj
Copy link
Copy Markdown
Contributor Author

@stianst before merging those changes we need to rename core-clients to core-protocols. Leaving that to you so nothing will be broken.

@stianst stianst self-assigned this Apr 7, 2026
@mabartos mabartos left a comment
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@abstractj @rmartinc @mposolda Just a few questions to clarify things :)

Comment thread .github/teams.yml
Comment on lines 19 to 21
- area/authentication
- area/authentication/webauthn
- area/login/ui
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure about responsibilities of the the core-protocols team, but these ones should be for the core-authn, right?

Comment thread .github/teams.yml
- area/authentication
- area/core
- area/identity-brokering
- area/saml
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it mean, the SAML is shared for the protocols and authn?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SAML is strictly speaking a protocol, but, as I usually managed the issues related to SAML, don't know who is going to be the responsible. @mposolda WDYT? Do we share SAML for the moment?

Comment thread .github/teams.yml
- area/identity-brokering
- area/saml
- area/test-framework
- area/token-exchange/subject-impersonation
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it intentional to have the area/token-exchange for core-protocols, and area/token-exchange/subject-impersonation for core-authn?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would assign TE as a whole to one or both teams. Assigning just a minor part makes no sense. If we should start doing the delegation part we can share the area/token-exchange for the moment.

@abstractj
Copy link
Copy Markdown
Contributor Author

@mabartos those labels were taken based on the issues assigned to the authN team - https://github.com/keycloak/keycloak/issues?q=sort%3Aupdated-desc%20is%3Aissue%20is%3Aopen%20label%3Ateam%2Fcore-authn. Now the team must review @rmartinc will review and probably suggest changes as you did.

@rmartinc rmartinc left a comment
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments...

Comment thread .github/teams.yml
- area/admin/ui
- area/authentication
- area/core
- area/identity-brokering
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one is right now for core-iam. I suppose that only the authentication stuff related to identity brokering is for us, not the identity provider implementation. In such case, I would say that this one should remain in core-iam, only the stuff that is related to authentication via identity providers is for us. They can assign to us issues that are more area/authentication than area/identity-brokering.

Comment thread .github/teams.yml
- area/authentication
- area/core
- area/identity-brokering
- area/saml
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SAML is strictly speaking a protocol, but, as I usually managed the issues related to SAML, don't know who is going to be the responsible. @mposolda WDYT? Do we share SAML for the moment?

Comment thread .github/teams.yml
- area/identity-brokering
- area/saml
- area/test-framework
- area/token-exchange/subject-impersonation
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would assign TE as a whole to one or both teams. Assigning just a minor part makes no sense. If we should start doing the delegation part we can share the area/token-exchange for the moment.

Signed-off-by: Alexander Schwartz <alexander.schwartz@ibm.com>
@ahus1
ahus1 commented Apr 13, 2026
Copy link
Copy Markdown
Member

The new team label team/core-authn is started to being used. As the file is not yet updated, the bug dashboards are incomplete.

I've reverted the change of the team/core-clients label to unblock this one and merge it, so the bug dashboard is up-to-date again.

Please handle any follow-up items in a follow-up pull request.

@ahus1
ahus1 merged commit cc2db82 into keycloak:main Apr 13, 2026
62 checks passed
@stianst stianst mentioned this pull request Jun 1, 2026
sashyo pushed a commit to tide-foundation/keycloak-IGA that referenced this pull request Jul 20, 2026
* Update with core authn team

Signed-off-by: Bruno Oliveira da Silva <bruno@abstractj.com>

* Revert core-protocols change to unblock this issue

Signed-off-by: Alexander Schwartz <alexander.schwartz@ibm.com>

---------

Signed-off-by: Bruno Oliveira da Silva <bruno@abstractj.com>
Signed-off-by: Alexander Schwartz <alexander.schwartz@ibm.com>
Co-authored-by: Alexander Schwartz <alexander.schwartz@ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

0