8000 [quarkus-next] Adapt LoggingDistTest to Quarkus access log masking an… by Pepo48 · Pull Request #48475 · keycloak/keycloak · GitHub
[go: up one dir, main page]
Skip to content

[quarkus-next] Adapt LoggingDistTest to Quarkus access log masking an… - #48475

Merged
Pepo48 merged 0 commit into
keycloak:quarkus-nextfrom
Pepo48:issue-48473
Apr 30, 2026
Merged

[quarkus-next] Adapt LoggingDistTest to Quarkus access log masking an…#48475
Pepo48 merged 0 commit into
keycloak:quarkus-nextfrom
Pepo48:issue-48473

Conversation

@Pepo48
@Pepo48 Pepo48 commented Apr 24, 2026
Copy link
Copy Markdown
Contributor

…d OTel sender changes

This deliberately targets quakus-next, hence it does not close its parent issue and should not be merged to main earlier than 3.34.0.CR1/3.35.0.CR1.

@Pepo48
Pepo48 requested review from a team April 24, 2026 16:16
@vmuzikar
vmuzikar commented Apr 24, 2026
Copy link
Copy Markdown
Contributor

Tests seem to be failing though, hence not merging yet.

@Pepo48
Pepo48 commented Apr 24, 2026 •
edited
Loading
Copy link
Copy Markdown
Contributor Author

Tests seem to be failing though, hence not merging yet.

Some failures are, of course, expected - quarkus-next is not fully stabilized. For now, just 3 logging tests in question is what is important to pass (see the parent issue).

Thanks for the review!

@keycloak-github-bot keycloak-github-bot Bot mentioned this pull request Apr 24, 2026
Closed
@Pepo48
Pepo48 commented Apr 24, 2026
Copy link
Copy Markdown
Contributor Author

All three tests in question (telemetryLogsEnabled, httpAccessLogMaskedCookies, httpAccessLogMaskedCookiesDiffFormat) passed. Thus, the PR is ready to be merged. JFTR, quarkus-next last night run vs this PR CI run.

The remaining httpAccessLogMaskedCookiesDiffFormat failure you can see this CI run is most likely caused by a flakiness. It's the same issue reported in #45522 and fixed by PR #45943, which missed the assertHttpAccessLogMaskedCookies method. So I assume a fix would be to wrap the assertion in Awaitility.await() like the fix did with other access log tests. But it's outside of the scope of this PR, not even exclusive to quarkus-next.
cc: @mabartos

@Pepo48
Pepo48 commented Apr 24, 2026
Copy link
Copy Markdown
Contributor Author

And indeed, you can see that after a rerun the whole job is green: https://github.com/keycloak/keycloak/actions/runs/24900404734/job/72964445442?pr=48475

shawkins
shawkins approved these changes Apr 25, 2026
View reviewed changes
@shawkins shawkins left a comment
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
github-actions Bot force-pushed the quarkus-next branch 5 times, most recently from 8f69314 to 21aa7fa Compare April 30, 2026 01:00
@Pepo48
Pepo48 merged this pull request into keycloak:quarkus-next Apr 30, 2026
129 of 139 checks passed
@Pepo48 Pepo48 mentioned this pull request Jul 29, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shawkins shawkins shawkins approved these changes
@vmuzikar vmuzikar vmuzikar approved these changes

Assignees

No one assigned

Labels

flaky-test team/cloud-native

Projects

None yet
< 45DF /form>

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Pepo48 @vmuzikar @shawkins
0