8000 Upgrade to Quarkus 3.37.4 by Pepo48 · Pull Request #51289 · keycloak/keycloak · GitHub
[go: up one dir, main page]
Skip to content

Upgrade to Quarkus 3.37.4 - #51289

Merged
vmuzikar merged 1 commit into
keycloak:mainfrom
Pepo48:issue-51273
Jul 31, 2026
Merged

Upgrade to Quarkus 3.37.4#51289
vmuzikar merged 1 commit into
keycloak:mainfrom
Pepo48:issue-51273

Conversation

@Pepo48
@Pepo48 Pepo48 commented Jul 29, 2026
Copy link
Copy Markdown
Contributor

Closes #51273

Apart from the version bumps, the PR contains cherry-picked quarkus-next fixes effective in <=3.37:

Once merged, I'll remove these commits from the quarkus-next branch to avoid conflicts.

@Pepo48
Pepo48 requested a review from a team as a code owner July 29, 2026 16:01
Copilot AI review requested due to automatic review settings July 29, 2026 16:01
@Pepo48
Pepo48 requested a review from a team as a code owner July 29, 2026 16:01
Copilot AI reviewed Jul 29, 2026
View reviewed changes
Copilot AI left a comment
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Upgrades Keycloak’s Quarkus stack to 3.37.4 and applies required compatibility updates.

Changes:

  • Aligns Quarkus-managed dependencies and plugins.
  • Adapts OpenTelemetry HTTP client instrumentation.
  • Updates tracing and logging assertions for changed upstream behavior.

Reviewed changes

Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.

File Description
pom.xml Updates Quarkus and aligned dependency versions.
OTelHttpClientFactory.java Uses the renamed OpenTelemetry builder API.
LoggingDistTest.java Updates telemetry-error and masking expectations.
TracingProviderTest.java Accepts randomized non-sampling trace flags.

Copilot AI review requested due to automatic review settings July 29, 2026 16:04
Copilot AI reviewed Jul 29, 2026
View reviewed changes
Copilot AI left a comment
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 4 changed files in this pull request and generated no new comments.

@Pepo48
Upgrade to Quarkus 3.37.4
0591f0e 
Closes keycloak#51273

Signed-off-by: Peter Zaoral <pzaoral@redhat.com>
Copilot AI review requested due to automatic review settings July 29, 2026 16:30
Copilot AI reviewed Jul 29, 2026
View reviewed changes
Copilot AI left a comment
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 4 out of 5 changed files in this pull request and generated no new comments.

keycloak-github-bot[bot]
keycloak-github-bot Bot reviewed Jul 29, 2026
View reviewed changes
@keycloak-github-bot keycloak-github-bot Bot left a comment
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unreported flaky test detected, please review

@keycloak-github-bot
keycloak-github-bot Bot commented Jul 29, 2026
Copy link
Copy Markdown

Unreported flaky test detected

If the flaky tests below are affected by the changes, please review and update the changes accordingly. Otherwise, a maintainer should report the flaky tests prior to merging the PR.

org.keycloak.testsuite.broker.KcOidcBrokerTest#loginWithExistingUserWithBruteForceEnabled

Keycloak CI - Java Distribution IT (windows-latest - temurin - 17)

org.openqa.selenium.TimeoutException: 
Expected condition failed: waiting for value to contain (ignoring case) "sign in to". Current value: "AUTH_RESPONSE" (tried for 5 second(s) with 500 milliseconds interval)
Build info: version: '4.28.1', revision: '73f5ad48a2'
System info: os.name: 'Windows Server 2025', os.arch: 'amd64', os.version: '10.0', java.version: '17.0.19'
Driver info: org.jboss.arquillian.drone.webdriver.htmlunit.DroneHtmlUnitDriver_ByGraphene
...

Report flaky test

shawkins
shawkins approved these changes Jul 29, 2026
View reviewed changes
@shawkins shawkins left a comment
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. It will be great to unblock work that has been waiting on the tls registry work from 3.36.

@michalvavrik
michalvavrik commented Jul 30, 2026
Copy link
Copy Markdown
Member

@Pepo48 why not 3.38.0 https://github.com/quarkusio/quarkus-platform/tags ?

@Pepo48
Pepo48 commented Jul 30, 2026 •
edited
Loading
Copy link
Copy Markdown
Contributor Author

@Pepo48 why not 3.38.0 https://github.com/quarkusio/quarkus-platform/tags ?

Because it wasn't just releasead when I was preparing this 😊

Since this one ready, tested and approved, I would proceed with it. I will prepare the 3.38 upgrade as a follow-up.

@Pepo48
Pepo48 commented Jul 30, 2026
Copy link
Copy Markdown
Contributor Author

@vmuzikar any objections?

shawkins
shawkins approved these changes Jul 30, 2026
View reviewed changes
@shawkins shawkins left a comment
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mabartos
mabartos commented Jul 31, 2026
Copy link
Copy Markdown
Member

@Pepo48 Hi Peter! Just out of curiosity; so the Keycloak 26.8 will use the next Quarkus LTS version?

vmuzikar
vmuzikar approved these changes Jul 31, 2026
View reviewed changes
@vmuzikar vmuzikar left a comment
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

@vmuzikar
vmuzikar commented Jul 31, 2026
Copy link
Copy Markdown
Contributor

so the Keycloak 26.8 will use the next Quarkus LTS version?

Yes! Quarkus 3.40 is the next LTS.

@vmuzikar
vmuzikar merged commit deb18b8 into keycloak:main Jul 31, 2026
95 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@shawkins shawkins shawkins approved these changes
@vmuzikar vmuzikar vmuzikar approved these changes
+2 more reviewers
@keycloak-github-bot keycloak-github-bot[bot] keycloak-github-bot[bot] left review comments
@michalvavrik michalvavrik michalvavrik approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

flaky-test team/cloud-native

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Upgrade to Quarkus 3.37.4

6 participants

@Pepo48 @michalvavrik @mabartos @vmuzikar @shawkins
0