8000 Upgrade webauthn4j to 0.30.3 by mabartos · Pull Request #48492 · keycloak/keycloak · GitHub
[go: up one dir, main page]
Skip to content

Upgrade webauthn4j to 0.30.3 - #48492

Merged
ahus1 merged 1 commit into
keycloak:mainfrom
mabartos:upgrade-webauthn4j
Apr 30, 2026
Merged

Upgrade webauthn4j to 0.30.3#48492
ahus1 merged 1 commit into
keycloak:mainfrom
mabartos:upgrade-webauthn4j

Conversation

@mabartos
@mabartos mabartos commented Apr 27, 2026 •
edited
Loading
Copy link
Copy Markdown
Member
  • Closes Upgrade webauthn4j to 0.30.3 #48420
  • Upgrade to the webauthn4j 0.30.3
  • Contains minimum changes - more wider work can be followed to get rid of deprecations
  • The latest release 0.31.3 requires Jackson version 3, and we're not there yet - IMHO, we should plan it for Keycloak 27.0.0
  • Remove unnecessary kerby-asn1 dependency (it was required in version 0.27.0, but not anymore in version 0.30.3)
  • previous versions of the artifact exist in the PNC, but the new one needs to be productized (cc: @pskopek)

cc: @keycloak/core-authn

@mabartos mabartos self-assigned this Apr 27, 2026
@mabartos
mabartos force-pushed the upgrade-webauthn4j branch from d4fb88a to b74b1ec Compare April 27, 2026 09:11
This was referenced Apr 27, 2026
Closed
Closed
@mabartos
mabartos force-pushed the upgrade-webauthn4j branch from b74b1ec to 2a0982e Compare April 27, 2026 11:37
@keycloak-github-bot keycloak-github-bot Bot mentioned this pull request Apr 27, 2026
Closed
@mabartos
Upgrade webauthn4j to 0.30.3
0df32d8 
Closes keycloak#48420

Signed-off-by: Martin Bartoš <mabartos@redhat.com>
@mabartos
mabartos force-pushed the upgrade-webauthn4j branch from 2a0982e to 0df32d8 Compare April 27, 2026 12:59
This was referenced Apr 27, 2026
Closed
Closed
Closed
Closed
keycloak-github-bot[bot]
keycloak-github-bot Bot reviewed Apr 27, 2026
View reviewed changes
@keycloak-github-bot keycloak-github-bot Bot left a comment
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unreported flaky test detected, please review

@keycloak-github-bot
keycloak-github-bot Bot commented Apr 27, 2026
Copy link
Copy Markdown

Unreported flaky test detected

If the flaky tests below are affected by the changes, please review and update the changes accordingly. Otherwise, a maintainer should report the flaky tests prior to merging the PR.

org.keycloak.testsuite.model.user.UserModelTest#testAddDirtyRemoveFederationUsersInTheSameGroupConcurrent

Keycloak CI - Store Model Tests

org.opentest4j.MultipleFailuresError: 
Multiple Failures (2 failures)
	java.lang.NullPointerException: Cannot invoke "org.keycloak.models.KeycloakSessionFactory.create()" because "factory" is null
	org.infinispan.commons.IllegalLifecycleStateException: Cache container has been stopped and cannot be reused. Recreate the cache container.
	Suppressed: java.lang.NullPointerException: Cannot invoke "org.keycloak.models.KeycloakSessionFactory.create()" because "factory" is null
...

Report flaky test

keycloak-github-bot[bot]
keycloak-github-bot Bot reviewed Apr 27, 2026
View reviewed changes
@keycloak-github-bot keycloak-github-bot Bot left a comment
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unreported flaky test detected, please review

@keycloak-github-bot
keycloak-github-bot Bot commented Apr 27, 2026
Copy link
Copy Markdown

Unreported flaky test detected

If the flaky tests below are affected by the changes, please review and update the changes accordingly. Otherwise, a maintainer should report the flaky tests prior to merging the PR.

org.keycloak.testsuite.model.user.UserModelTest#testAddDirtyRemoveFederationUsersInTheSameGroupConcurrent

Keycloak CI - Store Model Tests

org.opentest4j.MultipleFailuresError: 
Multiple Failures (2 failures)
	java.lang.NullPointerException: Cannot invoke "org.keycloak.models.KeycloakSessionFactory.create()" because "factory" is null
	org.infinispan.commons.IllegalLifecycleStateException: Cache container has been stopped and cannot be reused. Recreate the cache container.
	Suppressed: java.lang.NullPointerException: Cannot invoke "org.keycloak.models.KeycloakSessionFactory.create()" because "factory" is null
...

Report flaky test

@mabartos
mabartos marked this pull request as ready for review April 27, 2026 15:26
@mabartos
mabartos requested review from a team as code owners April 27, 2026 15:26
rmartinc
rmartinc approved these changes Apr 28, 2026
View reviewed changes
@rmartinc rmartinc left a comment
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mabartos! LGTM but I'm adding @pskopek who is the one that usually approved dependencies that should be compiled for downstream.

@rmartinc
rmartinc requested a review from pskopek April 28, 2026 08:05
@stianst
stianst commented Apr 30, 2026
Copy link
Copy Markdown
Contributor

@rmartinc @mabartos actually, the authn team is responsible for productizing the dependency, but that is not for upstream. Go ahead and merge this one, and figure out the productization after, but also please consider backporting this to 26.6.

@mabartos
mabartos removed the request for review from pskopek April 30, 2026 07:01
@ahus1
ahus1 merged commit 3a825c8 into keycloak:main Apr 30, 2026
146 of 148 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ahus1 ahus1 ahus1 approved these changes
@rmartinc rmartinc rmartinc approved these changes
+1 more reviewer
@keycloak-github-bot keycloak-github-bot[bot] keycloak-github-bot[bot] left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

@mabartos mabartos

Labels

flaky-test team/cloud-native team/core-authn

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Upgrade webauthn4j to 0.30.3

4 participants

@mabartos @stianst @ahus1 @rmartinc
0