8000 Upgrade webauthn4j to 0.30.3 by mabartos · Pull Request #48492 · keycloak/keycloak · GitHub
[go: up one dir, main page]
Skip to content

Upgrade webauthn4j to 0.30.3 #48492

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ahus1 merged 1 commit into from
Apr 30, 2026
Merged

Upgrade webauthn4j to 0.30.3 #48492

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 1 addition & 7 deletions pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -227,8 +227,7 @@
</testframework.surefire.args>

<!-- webauthn support -->
<webauthn4j.version>0.29.3.RELEASE</webauthn4j.version>
<org.apache.kerby.kerby-asn1.version>2.0.3</org.apache.kerby.kerby-asn1.version>
<webauthn4j.version>0.30.3.RELEASE</webauthn4j.version>

<!-- Used to test SAML Galleon feature-pack layers discovery -->
<version.org.wildfly.glow>1.0.0.Alpha8</version.org.wildfly.glow>
Expand Down Expand Up @@ -1213,11 +1212,6 @@
<artifactId>webauthn4j-util</artifactId>
<version>${webauthn4j.version}</version>
</dependency>
<dependency>
<groupId>org.apache.kerby</groupId>
<artifactId>kerby-asn1</artifactId>
<version>${org.apache.kerby.kerby-asn1.version}</version>
</dependency>

<!-- used in server-dist build while provisioning the distribution -->
<dependency>
Expand Down
10 changes: 0 additions & 10 deletions quarkus/runtime/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -513,16 +513,6 @@
</exclusion>
</exclusions>
</dependency>
<dependency>
<groupId>org.apache.kerby</groupId>
<artifactId>kerby-asn1</artifactId>
<exclusions>
<exclusion>
<groupId>*</groupId>
<artifactId>*</artifactId>
</exclusion>
</exclusions>
</dependency>
<dependency>
<groupId>org.freemarker</groupId>
<artifactId>freemarker</artifactId>
Expand Down
2 changes: 1 addition & 1 deletion ...c/main/java/org/keycloak/authentication/authenticators/browser/WebAuthnAuthenticator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -170,7 +170,7 @@ public void action(AuthenticationFlowContext context) {

Origin origin = new Origin(baseUrl);
Challenge challenge = new DefaultChallenge(context.getAuthenticationSession().getAuthNote(WebAuthnConstants.AUTH_CHALLENGE_NOTE));
ServerProperty server = new ServerProperty(origin, rpId, challenge, null);
ServerProperty server = new ServerProperty(origin, rpId, challenge);

byte[] credentialId = Base64Url.decode(params.getFirst(WebAuthnConstants.CREDENTIAL_ID));
byte[] clientDataJSON = Base64Url.decode(params.getFirst(WebAuthnConstants.CLIENT_DATA_JSON));
Expand Down
2 changes: 1 addition & 1 deletion services/src/main/java/org/keycloak/authentication/requiredactions/WebAuthnRegister.java
View file
Open in desktop
Original file line number Diff line number Diff line change
< 6A2B tool-tip id="tooltip-03b3dd1a-43e9-4707-85d5-6b48f2f85510" for="expand-up-link-0-diff-0e595691dcd2d8743344ba15e79236428e5d05b01217687db5081b145dbdfb05" popover="manual" data-direction="ne" data-type="label" data-view-component="true" class="sr-only position-absolute">Expand Up @@ -247,7 +247,7 @@ public void processAction(RequiredActionContext context) {
.collect(Collectors.toSet());
allOrigins.add(origin);
Challenge challenge = new DefaultChallenge(context.getAuthenticationSession().getAuthNote(WebAuthnConstants.AUTH_CHALLENGE_NOTE));
ServerProperty serverProperty = new ServerProperty(allOrigins, rpId, challenge, null);
ServerProperty serverProperty = new ServerProperty(allOrigins, rpId, challenge);
// check User Verification by considering a malicious user might modify the result of calling WebAuthn API
boolean isUserVerificationRequired = policy.getUserVerificationRequirement().equals(Constants.WEBAUTHN_POLICY_OPTION_REQUIRED);

Expand Down
Loading
0