Repository navigation
mac: release the IPC server receive right - #249
Merged
schopin-mozilla merged 1 commit intoOct 26, 2026
Merged
Conversation
bootstrap_check_in returns a receive right, but mach_port_deallocate only releases send, send-once, or dead-name references. Release the receive right with mach_port_mod_refs instead. Add a regression test that checks the port name is removed after dropping a server with no send references. Refs: zed-industries/zed#57664
schopin-mozilla
approved these changes
Oct 26, 2026
AurySepe
pushed a commit
to AurySepe/zed
that referenced
this pull request
Oct 26, 2026
Closes zed-industries#57664 Updates `crash-context` transitive dependency (ergo the `patch` section) to include rust-minidump/minidump-writer#249 fix: given the latest release was a few months ago, decided to use the git SHA pointer. Release Notes: - Fixed "Zed quit unexpectedly" when quitting via ⌘ + Q
slgobinath
pushed a commit
to slgobinath/bench
that referenced
this pull request
Nov 6, 2026
Closes zed-industries#57664 Updates `crash-context` transitive dependency (ergo the `patch` section) to include rust-minidump/minidump-writer#249 fix: given the latest release was a few months ago, decided to use the git SHA pointer. Release Notes: - Fixed "Zed quit unexpectedly" when quitting via ⌘ + Q (cherry picked from commit 087340e)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
bootstrap_check_inreturns a receive right, but the IPC server drops it withmach_port_deallocate, which only releases send, send-once, or dead-name references.This was found while investigating Zed’s
EXC_GUARD / INVALID_RIGHTcrash on quit.