8000 mac: release the IPC server receive right by SomeoneToIgnore · Pull Request #249 · rust-minidump/minidump-writer · GitHub
[go: up one dir, main page]
Skip to content

mac: release the IPC server receive right #249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
schopin-mozilla merged 1 commit into from
Oct 26, 2026
Merged

mac: release the IPC server receive right #249

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
58 changes: 57 additions & 1 deletion crates/crash-context/src/mac/ipc.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -417,7 +417,12 @@ impl Drop for Server {
fn drop(&mut self) {
// SAFETY: syscall
unsafe {
mach_port::mach_port_deallocate(mach_task_self(), self.port);
mach_port::mach_port_mod_refs(
mach_task_self(),
self.port,
port::MACH_PORT_RIGHT_RECEIVE,
-1,
);
}
}
}
Expand Down Expand Up @@ -560,3 +565,54 @@ impl Drop for AckReceiver {
}
}
}

#[cfg(test)]
mod tests {
use super::{Server, kern_return_t, port};
use mach2::{
kern_return::{KERN_INVALID_NAME, KERN_SUCCESS},
traps::mach_task_self,
};
use std::ffi::CString;

#[test]
fn server_drop_releases_receive_right() {
let name = CString::new(format!("crash-context.server-drop.{}", std::process::id()))
.expect("invalid service name");
let server = Server::create(&name).expect("failed to create server");
let task = unsafe { mach_task_self() };
let port = server.port;
let mut references = 0;

assert_eq!(
unsafe {
mach_port_get_refs(task, port, port::MACH_PORT_RIGHT_RECEIVE, &mut references)
},
KERN_SUCCESS
);
assert_eq!(references, 1);
assert_eq!(
unsafe { mach_port_get_refs(task, port, port::MACH_PORT_RIGHT_SEND, &mut references) },
KERN_SUCCESS
);
assert_eq!(references, 0);

drop(server);

assert_eq!(
unsafe {
mach_port_get_refs(task, port, port::MACH_PORT_RIGHT_RECEIVE, &mut references)
},
KERN_INVALID_NAME
);
}

unsafe extern "C" {
fn mach_port_get_refs(
task: port::mach_port_t,
name: port::mach_port_name_t,
right: port::mach_port_right_t,
references: *mut port::mach_port_urefs_t,
) -> kern_return_t;
}
}
Loading
0