Repository navigation
refactor(adapters)!: remove respondToolResult; share message builder and queue map - #198
Merged
Merged
Conversation
This was referenced Oct 26, 2026
8000
Merged
geminixiang
marked this pull request as ready for review
October 26, 2026 09:52
Owner
Author
|
Slack E2E passed 26/26 on this branch (run 40300808883). |
…thod No production code has called ConversationResponder.respondToolResult since afda4ab, so the method, the ChatToolResult type, each platform's tool-result formatter, and the renderer's formatToolResult hook were dead code. BREAKING CHANGE: ConversationResponder no longer declares respondToolResult and the package no longer exports ChatToolResult. Embedders that implement ConversationResponder should delete their respondToolResult method and any ChatToolResult import (deploy/examples/embedder is updated).
…rge Slack intake createEventMessage in shared.ts builds a platform message from an event. Telegram passes deriveSessionKey; Discord and GitHub pass persistentTopLevelSessionKey. The discord/github clone budget drops to zero. MessagingQueueMap replaces the four getQueue copies and keeps Slack's rules from ADR 0027: a queue created after stop is closed, and Slack's stop does not wait for its queues to drain. Slack's app_mention and message handlers share one dispatch tail with the session key computed once, keeping ack order, the Jev auto-reply check after task control, and each handler's pre-startup log wording.
geminixiang
force-pushed
the
refactor/simplify-adapters
branch
from
October 26, 2026 10:48
875c141 to
76935b3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stage 2 of
docs/research/simplify-modules-2026-10.md(#196). 33 files, +211 / −322.ConversationResponder.respondToolResult,ChatToolResult, and the per-platform tool-result formatterscreateEventMessageinshared.tsfor Discord, GitHub, TelegramderiveSessionKey; Discord and GitHub keep the persistent-top-level key. Clone budget discord↔github → 0MessagingQueueMapreplaces fourgetQueuecopiesstop()and does not awaitclose()(ADR 0027); 4 new unit testshandleAppMention/handleMessageEventsharedispatchIncoming; session key computed oncestop/enqueueEvent/log helpersstops differ in awaitingCompatibility
Breaking for embedders:
ConversationResponder.respondToolResultand the exportedChatToolResulttype are removed. A responder that importsChatToolResultor is an object literal typed asConversationResponderwith that method fails to compile; delete the method.deploy/examples/embedderis updated. Needs a release-note line.Verification
npm run typechecknpm testnpm run duplicationEval: existing tests, typecheck, and source guards serve as the before/after baseline, as agreed for behavior-preserving refactors.
Pending: this changes the Slack intake path, so
slack-e2e.ymlmust pass before merge. Draft until then.