Repository navigation
refactor(harness): drop the startup prompt, dead tool state, and duplicate label helpers - #201
Merged
Merged
Conversation
geminixiang
marked this pull request as ready for review
October 26, 2026 09:52
Owner
Author
|
Slack E2E passed 26/26 on this branch (run 40301300494). |
- Drop the runner's startup system prompt built for a fake "chat" platform; every run sets its own before tools install. Remove the unused conversationId param and the prepareRunnerTurn pass-through. - Remove the session's write-only toolArgs map and inline emitToolEnd. - Remove the test-only inline-skill path and the skill loader's source argument that loadOfficeSkills overwrote. - One withLabelParameter/withoutLabel helper in host-fn-tool.ts replaces four copies, keeping the optional label for read/write/edit/bash. - start_task declares callers: ["model"] itself; drop unreachable unbound-function throws in task tools. - Match pi-ai's only tool-call part type and share toolLabel between run-events and presenter; fold presenter pass-throughs and duplicate notice cases. - src/events/index.ts owns the scheduled-event run id (eventRunId, isEventRunId, eventRunName); runner, prompt, scheduler and memory capture use it.
geminixiang
force-pushed
the
refactor/simplify-harness
branch
from
October 26, 2026 10:44
e516858 to
9e64591
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stage 1 of
docs/research/simplify-modules-2026-10.md(#196). 18 files, +137 / −268 (production −111 net).conversationIdparam, andprepareRunnerTurnmikansection installs; no model read the startup one.systemPromptoption defaults to""session.ts'stoolArgsmap andemitToolEndscopedSkillsalone setssourceinlinewithLabelParameter(schema, "required" | "optional")/withoutLabelreplace four copiesstart_task'scallers: ["model"]lives increateTaskToolpart.type === "toolCall"; presenter uses onetoolLabelgetCurrentStepleft alone: unifying them would change text for padded or non-string labelspresentNoticeeventRunId/isEventRunId/eventRunNameinsrc/events/own theevent:run nameevent:; add a fact-owner guard after #198Visible effects: the "Skipping conversation skill entry (symlink)" warning now logs once per run instead of also at runner creation.
Verification
npm run typechecknpm testnpm run duplicationPending: this changes the run loop, so
slack-e2e.ymlmust pass before merge. Draft until then.